Fix NullPointerException on tomcat #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
laurit
commented
Jul 28, 2021
| @@ -31,8 +31,6 @@ public void addRequestAsyncListener( | |||
| request | |||
| .getAsyncContext() | |||
| .addListener(new Listener(listener), request, (HttpServletResponse) response); | |||
| } else { | |||
There was a problem hiding this comment.
removed this branch to make tests fail when response is null
|
|
||
| transformer.applyAdviceToMethod( | ||
| isMethod() | ||
| .and(named("postParseRequest")) |
There was a problem hiding this comment.
Adapter doesn't have this method. Is there any reason why we're not instrumenting CoyoteAdapter?
There was a problem hiding this comment.
Thanks. Didn't even realize that it wasn't using CoyoteAdapter.
mateuszrzeszutek
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3673
We store response in a request attribute and use it later to add async completion listener. Currently on tomcat we touch request a bit too early when it ins't fully initialized. Either
org.apache.coyote.Requestdoesn't have a reference toHttpServletRequestin which case we just don't link response to request ororg.apache.coyote.Requesthas reference toHttpServletRequestwhich is empty (request was recycled, reusing a previous request) in which case depending on tomcat version we could get aNullPointerException.