Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal instrumentations should always be enabled by default #3257

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Internal instrumentations should always be enabled by default #3257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...etry/javaagent/instrumentation/internal/classloader/ClassLoaderInstrumentationModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ public ClassLoaderInstrumentationModule() {
super("internal-class-loader");
}

@Override
public boolean defaultEnabled() {
// internal instrumentations are always enabled by default
return true;
}

@Override
public boolean isHelperClass(String className) {
return className.equals("io.opentelemetry.javaagent.tooling.Constants");
Expand Down
6 changes: 6 additions & 0 deletions ...entelemetry/javaagent/instrumentation/internal/osgi/EclipseOsgiInstrumentationModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ public EclipseOsgiInstrumentationModule() {
super("internal-eclipse-osgi");
}

@Override
public boolean defaultEnabled() {
// internal instrumentations are always enabled by default
return true;
}

@Override
public List<TypeInstrumentation> typeInstrumentations() {
return singletonList(new EclipseOsgiInstrumentation());
Expand Down
6 changes: 6 additions & 0 deletions ...io/opentelemetry/javaagent/instrumentation/internal/proxy/ProxyInstrumentationModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ public ProxyInstrumentationModule() {
super("internal-proxy");
}

@Override
public boolean defaultEnabled() {
// internal instrumentations are always enabled by default
return true;
}

@Override
public List<TypeInstrumentation> typeInstrumentations() {
return singletonList(new ProxyInstrumentation());
Expand Down
6 changes: 6 additions & 0 deletions ...avaagent/instrumentation/internal/urlclassloader/UrlClassLoaderInstrumentationModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ public UrlClassLoaderInstrumentationModule() {
super("internal-url-class-loader");
}

@Override
public boolean defaultEnabled() {
// internal instrumentations are always enabled by default
return true;
}

@Override
public List<TypeInstrumentation> typeInstrumentations() {
return singletonList(new UrlClassLoaderInstrumentation());
Expand Down