Split akka actor instumentation #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
Split akka actor instrumentation into actor instrumentation and fork join instrumentation. Fork join code is gone from the latest akka and this makes muzzle fail the whole instrumentation because of mismatched references.
👍 and we can move it over to contrib when we move over old instrumentation versions
This pr also enables akka instrumentation by default. If anybody knows the reason why it was disabled then please speak up.
IIRC (which I may not) we disabled it by default in #911 because it was causing context leaks in the akka http tests. I'm good with enabling it.
Comment on lines
+10
to
+19
| pass { | ||
| group = 'com.typesafe.akka' | ||
| module = 'akka-actor_2.12' | ||
| versions = "[2.5.0,)" | ||
| } | ||
| pass { | ||
| group = 'com.typesafe.akka' | ||
| module = 'akka-actor_2.13' | ||
| versions = "(,)" | ||
| } |
| jvmArgs '-Dotel.instrumentation.akka-actor.enabled=true' | ||
| if (findProperty('testLatestDeps')) { | ||
| configurations { | ||
| // akka artifact name is different for regular and latest tests |
mateuszrzeszutek
approved these changes
Jun 3, 2021
robododge
pushed a commit
to robododge/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split akka actor instrumentation into actor instrumentation and fork join instrumentation. Fork join code is gone from the latest akka and this makes muzzle fail the whole instrumentation because of mismatched references.
This pr also enables akka instrumentation by default. If anybody knows the reason why it was disabled then please speak up.