Add an optimized Attributes implementation for instrumenter #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
anuraaga
commented
May 30, 2021
| * couple of methods still require copying to satisfy the interface contracts, but in practice | ||
| * should never be called by user code even though they can. | ||
| */ | ||
| final class UnsafeAttributes extends HashMap<AttributeKey<?>, Object> |
There was a problem hiding this comment.
@jkwatson It's your favorite pattern again :)
trask
approved these changes
May 30, 2021
|
|
||
| Context context = parentContext; | ||
|
|
||
| for (RequestListener requestListener : requestListeners) { | ||
| context = requestListener.start(context, attributes); | ||
| } | ||
|
|
||
| attributes.forEach((key, value) -> spanBuilder.setAttribute((AttributeKey) key, value)); | ||
| spanBuilder.setAllAttributes(attributes); |
There was a problem hiding this comment.
any ideas how we can init the SpanBuilder with the already built Attributes map, to avoid this copy?
There was a problem hiding this comment.
Hmm - I guess it requires an internal use API for that in the SDK. We can try it but it'll be more hacky.
There was a problem hiding this comment.
just to clarify, did not mean for this pr, something (possibly) for the future..
robododge
pushed a commit
to robododge/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that this is being used in much of our instrumentation better fix the performance regression :)
After
Before