Fix payara windows image #2880
Merged
Fix payara windows image #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Apr 28, 2021
| :: after that place options into configuration xml after <jvm-options>-server</jvm-options> | ||
| SET IN_CONF_FILE=/server/glassfish/domains/domain1/config/domain.xml | ||
| SET OUT_CONF_FILE=/server/glassfish/domains/domain1/config/domain.xml | ||
| powershell -command "$opts='<jvm-options>' + $env:JVM_ARGS + '</jvm-options>'; $opts=$opts -replace ' ', '</jvm-options><jvm-options>'; (gc $env:IN_CONF_FILE) -replace '<jvm-options>-server</jvm-options>', ('<jvm-options>-server</jvm-options>' + $opts) | sc $env:OUT_CONF_FILE" |
There was a problem hiding this comment.
Are these JVM_ARGS dynamic? I mean can we already bake them into image itself?
There was a problem hiding this comment.
JVM_ARGS currently contains just the path to our agent which really isn't dynamic, but as we can pass it as an environment variable for all other servers it doesn't make sense to bake this into image for only this server. Also sometimes it is useful to pass additional arguments like -verbose:class for debugging purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payara is started through a launcher process so adding agent to jvm arguments just adds it to the launcher not actual server.