Async @WithSpan Instrumentation for Guava ListenableFuture #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaloFour
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
| import io.opentelemetry.instrumentation.api.tracer.async.AsyncSpanEndStrategies; | ||
| import io.opentelemetry.instrumentation.guava.GuavaAsyncSpanEndStrategy; | ||
|
|
||
| public class InstrumentationHelper { |
There was a problem hiding this comment.
Nit: can you make it final and add a private constructor?
| AsyncSpanEndStrategies.getInstance().registerStrategy(GuavaAsyncSpanEndStrategy.INSTANCE); | ||
| } | ||
|
|
||
| public static void initialize() {} |
There was a problem hiding this comment.
Please add a comment explaining why it is important to call this method even if it does nothin (static initializer on class load)
mateuszrzeszutek
approved these changes
Apr 19, 2021
iNikem
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds AsyncSpanEndStrategy that ends the span for a method annotated with
@WithSpanwhen the returned Guava ListenableFuture is completed.