Finish Netty 4.1 spans after response has completed not when it started. #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
|
@iNikem your favorite instrumentation! |
iNikem
approved these changes
Mar 26, 2021
Comment on lines
37
to
42
| // Headers before body has been sent, store them to use when finishing the span. | ||
| ctx.channel().attr(HTTP_RESPONSE).set((HttpResponse) msg); | ||
| } else if (msg instanceof LastHttpContent) { | ||
| // Not a FullHttpResponse so this is content that has been sent after headers. Finish the | ||
| // span using what we stored in attrs. | ||
| tracer().end(context, ctx.channel().attr(HTTP_RESPONSE).get()); |
There was a problem hiding this comment.
I find it confusing that you talk about "sending" here. This is client response handler, it receives data, not sends.
trask
approved these changes
Mar 26, 2021
...ntelemetry/javaagent/instrumentation/netty/v4_1/client/HttpClientResponseTracingHandler.java
Outdated
Show resolved
Hide resolved
...ntelemetry/javaagent/instrumentation/netty/v4_1/server/HttpServerResponseTracingHandler.java
Outdated
Show resolved
Hide resolved
...ntelemetry/javaagent/instrumentation/netty/v4_1/server/HttpServerResponseTracingHandler.java
Outdated
Show resolved
Hide resolved
…ntelemetry/javaagent/instrumentation/netty/v4_1/client/HttpClientResponseTracingHandler.java Co-authored-by: Trask Stalnaker <[email protected]>
…ntelemetry/javaagent/instrumentation/netty/v4_1/server/HttpServerResponseTracingHandler.java Co-authored-by: Trask Stalnaker <[email protected]>
…ntelemetry/javaagent/instrumentation/netty/v4_1/server/HttpServerResponseTracingHandler.java Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we end an outbound span as soon as headers are sent, even if the data is chunked and it will take some time to send it all. We should end the span after the last (potentially only but still should wait for the I/O) write is finished instead.
Guessing this applies to other Netty instrumentations too but just started with 4.1 to confirm the approach.