Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Camel - S3 to SQS propagation impl + tests #2583

Merged
merged 4 commits into from Mar 19, 2021
Merged

Apache Camel - S3 to SQS propagation impl + tests #2583

merged 4 commits into from Mar 19, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 16, 2021

  • enabling S3 to SQS propagation with Apache Camel
  • tests (only for live AWS currently!)

NOTE:
After all Camel - related PRs are merged I intend to file a separate clean-up one with uniform AWS communication, test setup (spring camel vs infra preparation) and span assertions (improving readability)

@ghost
Copy link
Author

ghost commented Mar 16, 2021

Build failed, seems unrelated, rebased to check.

@iNikem
Copy link
Contributor

iNikem commented Mar 16, 2021

@kubawach Please rebase again. Main branch failure was fixed

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, maybe we can add the unit test in another PR if too busy but would be nice

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iNikem iNikem merged commit 4e7d43e into open-telemetry:main Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants