Use reflection to get request metadata instead of instrumentation. #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
anuraaga
commented
Mar 5, 2021
| @@ -258,6 +258,7 @@ class Aws1ClientTest extends AgentInstrumentationSpecification { | |||
| "aws.endpoint" "https://s3.amazonaws.com" | |||
| "aws.operation" "HeadBucket" | |||
| "aws.agent" "java-aws-sdk" | |||
| "aws.bucket.name" "someBucket" | |||
There was a problem hiding this comment.
And somehow improved coverage!
This was referenced Mar 5, 2021
Merged
mateuszrzeszutek
approved these changes
Mar 5, 2021
trask
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what we do in aws sdk v2. For #2502, while we may need to keep some of the special javaagent instrumentation to work around bugs that will not be workaroundable in library instrumentation, the
RequestInstrumentationis the one that has the largest impact on library instrumentation right now.