Support multiple exporters via OTLP_EXPORTER config #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
requested review from
anuraaga,
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
Signed-off-by: Pavol Loffay <[email protected]>
|
@pavolloffay please run |
iNikem
reviewed
Sep 23, 2020
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/TracerInstaller.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
|
@iNikem I have updated the PR |
iNikem
reviewed
Sep 23, 2020
README.md
Outdated
|
|
||
| | System property | Environment variable | Purpose | | ||
| |--------------------------|--------------------------|----------------------------------------------------------------------------------------------------| | ||
| | otel.exporter | OTEL_EXPORTER= | To select exporter e.g. `otlp,jaeger`. Defaults to `otlp` | |
iNikem
approved these changes
Sep 23, 2020
Signed-off-by: Pavol Loffay <[email protected]>
|
am I right that next values for OTEL_EXPORTER are supported: "otlp_span", "otlp_metric"? (https://github.com/open-telemetry/opentelemetry-specification/blob/2088381f57004be1de4fa16e0c2adeea04cf2ce2/specification/sdk-environment-variables.md#exporter-selection) so if I specify |
|
Hey @malafeev, |
|
created #1250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay [email protected]
Resolves #496
PS: my first PR to this repo, I might have done smth wrong.