Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear context propagation virtual field #12397

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Oct 4, 2024

Related to #12303
Set field to null after restoring context or when task submission fails.

@laurit laurit requested a review from a team as a code owner October 4, 2024 07:13
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -106,6 +109,7 @@ public static void cleanUpAfterSubmit(
exceptions.
*/
propagatedContext.clear();
virtualField.set(task, null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a comment here that this is only needed for cleaning up the fallback map?

or alternatively, do we want to just think of this as a "more correct" behavior?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment. I think that with fallback map we need to do this, though ideally the fallback shouldn't be used at all which is what we really need to fix.

@laurit laurit merged commit 77be7c6 into open-telemetry:main Oct 8, 2024
56 checks passed
@laurit laurit deleted the clear-context-field branch October 8, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants