Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep junit extensions in static fields #12166

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Keep junit extensions in static fields #12166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...t/java/io/opentelemetry/instrumentation/awssdk/v2_2/Aws2ClientNotRecordHttpErrorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@

public class Aws2ClientNotRecordHttpErrorTest extends AbstractAws2ClientRecordHttpErrorTest {
@RegisterExtension
public final LibraryInstrumentationExtension testing = LibraryInstrumentationExtension.create();
public static final LibraryInstrumentationExtension testing =
LibraryInstrumentationExtension.create();

@Override
public ClientOverrideConfiguration.Builder createOverrideConfigurationBuilder() {
Expand Down
2 changes: 1 addition & 1 deletion ...n/rmi/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/rmi/RmiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class RmiTest {
private static Registry serverRegistry;
private static Registry clientRegistry;

@RegisterExtension final AutoCleanupExtension autoCleanup = AutoCleanupExtension.create();
@RegisterExtension static final AutoCleanupExtension autoCleanup = AutoCleanupExtension.create();

@BeforeAll
static void setUp() throws Exception {
Expand Down
3 changes: 2 additions & 1 deletion ...ntelemetry/instrumentation/spring/security/config/v6_0/EnduserAttributesCapturerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@

public class EnduserAttributesCapturerTest {

@RegisterExtension InstrumentationExtension testing = LibraryInstrumentationExtension.create();
@RegisterExtension
static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();

@Test
void nothingEnabled() {
Expand Down
Loading