Logback MDC auto-instrumentation gets muzzled and does not work #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
| public static void onExit( | ||
| @Advice.This ILoggingEvent event, | ||
| @Advice.Return(typing = Typing.DYNAMIC, readOnly = false) Map<String, String> contextData) { | ||
| if (contextData != null && contextData.containsKey("traceId")) { |
There was a problem hiding this comment.
I'll replace "traceId" and others either here or in #1200 - depending on which one gets merged first.
trask
reviewed
Sep 16, 2020
...n/java/io/opentelemetry/instrumentation/auto/logback/v1_0_0/LoggingEventInstrumentation.java
Outdated
Show resolved
Hide resolved
iNikem
approved these changes
Sep 16, 2020
anuraaga
reviewed
Sep 16, 2020
...ck-1.0.0/library/src/main/java/io/opentelemetry/instrumentation/logback/v1_0_0/UnionMap.java
Show resolved
Hide resolved
…entelemetry/instrumentation/auto/logback/v1_0_0/LoggingEventInstrumentation.java Co-authored-by: Trask Stalnaker <[email protected]>
Moved UnionMap to internal package
mateuszrzeszutek
force-pushed
the
fix-logback-auto-instrumentation
branch
from
6f4d05d to
3e560f6
Compare
anuraaga
approved these changes
Sep 16, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1201