Instrument ConnectionSource in Akka/Pekko HTTP Servers #11103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
laurit
approved these changes
Apr 12, 2024
trask
approved these changes
Apr 12, 2024
| @@ -7,7 +7,7 @@ muzzle { | |||
| pass { | |||
| group.set("com.typesafe.akka") | |||
| module.set("akka-actor_2.11") | |||
| versions.set("[2.5,)") | |||
| versions.set("[2.5,2.6)") // Akka's custom ForkJoin was removed in 2.6, replaced by the java.concurrent version | |||
There was a problem hiding this comment.
akka-actor_2.11 doesn't look like it goes above 2.5.x
maybe instead (or in addition), add
pass {
group.set("com.typesafe.akka")
module.set("akka-actor_2.12")
versions.set("[2.5,2.6)") // Akka's custom ForkJoin was removed in 2.6, replaced by the java.concurrent version
assertInverse.set(true)
}
There was a problem hiding this comment.
Good point! Pushed a new commit with that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Akka/Pekko have a fourth way of binding a route to a server: the ConnectionSource. The ConnectionSource returns a
Source[Http.IncomingConnection, Future[ServerBinding]], which you then use Akka Streams mechanics to set up a processing pipeline for each IncomingConnection element. Running the built Stream starts the Server, as seen in the new test file.