Support RESTeasy 4.0 version in unit tests #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
changed the title
mateuszrzeszutek
force-pushed
the
resteasy-4.0
branch
2 times, most recently
from
aa118db to
67018d6
Compare
mateuszrzeszutek
force-pushed
the
resteasy-4.0
branch
2 times, most recently
from
496c5ae to
6bd67fb
Compare
mateuszrzeszutek
force-pushed
the
resteasy-4.0
branch
4 times, most recently
from
ea9d277 to
0603649
Compare
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
Can you explain this a little more? I haven't noticed 4.0 version in any changed files :) |
Sure! RESTeasy changed their module naming scheme in 4.0: before it was always named latestDepTestLibrary group: 'org.jboss.resteasy', name: 'resteasy-core', version: '+'
}
if (findProperty('testLatestDeps')) {
configurations {
testImplementation.exclude group: 'org.jboss.resteasy', module: 'resteasy-jaxrs'
}
}where for the |
iNikem
approved these changes
Sep 9, 2020
mateuszrzeszutek
force-pushed
the
resteasy-4.0
branch
from
0603649 to
068ccae
Compare
trask
reviewed
Sep 9, 2020
.../io/opentelemetry/instrumentation/auto/jaxrs/v2_0/AbstractRequestContextInstrumentation.java
Show resolved
Hide resolved
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-3.1/jaxrs-2.0-resteasy-3.1.gradle
Show resolved
Hide resolved
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-3.1/jaxrs-2.0-resteasy-3.1.gradle
Show resolved
Hide resolved
* Split jaxrs-2.0 into jaxrs-2.0-common and jaxrs-2.0-testing (similar to e.g. play) * Support newest RESTEasy version in unit tests
Co-authored-by: Trask Stalnaker <[email protected]>
mateuszrzeszutek
force-pushed
the
resteasy-4.0
branch
from
c4a4b5c to
6639bae
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpanWithScopeusagesThis PR can only be merged after #1083 is solved (#1167 merged) -- before that happens
./gradlew :instrumentation:jaxrs:jaxrs-2.0:jaxrs-2.0-resteasy-3.1:test -PtestLatestDeps=truewill always fail.