Preserve attribute type for logback key value pairs #10781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbisutti
approved these changes
Mar 8, 2024
steverao
reviewed
Mar 8, 2024
| if (keyValuePair.value != null) { | ||
| attributes.put(getAttributeKey(keyValuePair.key), keyValuePair.value.toString()); | ||
| if (value instanceof Boolean) { |
There was a problem hiding this comment.
Might it be more friendly for code reading by adding some comments explaining what types are processed now?
There was a problem hiding this comment.
I'm not sure what comment you are asking for.
There was a problem hiding this comment.
I'm not sure what comment you are asking for.
I mean we can add some comment to describe what types are supported and what types are not supported to preserve attribute type now.
trask
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
👍 this makes sense to me from the perspective of log bridging
cc @jack-berg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10776
Preserve attribute type for attributes created for logback key value pairs. Type is preserved only for primitives and their wrapper types, arrays and lists are not handled.