Fix native tests

[zeitlinger]

Background: spring starter shouldn't depend on spring-boot-resources, which uses snake yaml, which doesn't work with graal native

[trask]

Looks like native tests still failing?

[zeitlinger]

Looks like native tests still failing?

But not failing in #10636 - flaky?

@jeanbisutti can you take a look?

[jeanbisutti]

Looks like native tests still failing?

But not failing in #10636 - flaky?

@jeanbisutti can you take a look?

There are two problems leading to the failure of the OpenTelemetry starter tests in the native mode. Please see #10634 (comment).

[trask]

spring starter shouldn't depend on spring-boot-resources, which uses snake yaml, which doesn't work with graal native

isn't the snake yaml problem better solved by splitting out the javaagent resource detector (as done in #10636)?

EDIT thanks @laurit for the explanation #10636 (comment)

[laurit]

spring starter shouldn't depend on spring-boot-resources, which uses snake yaml, which doesn't work with graal native

isn't the snake yaml problem better solved by splitting out the javaagent resource detector (as done in #10636)?

here we remove the dependency on the spring-boot-resources that depends on snakeyaml

[trask]

should we rename spring-boot-resources/library to spring-boot-resources/javaagent? since only intended to be used by java agent?

[laurit]

should we rename spring-boot-resources/library to spring-boot-resources/javaagent? since only intended to be used by java agent?

we use it inside the agent but there is nothing there that prevents it from being used as a library similarly to https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/resources/library

[trask]

https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/resources/library seem useful outside of the java agent, but wondering why a non-java agent user would want to use spring-boot-resources/library compared to using BuildProperties-based service name / service version detectors?

[laurit]

https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/resources/library seem useful outside of the java agent, but wondering why a non-java agent user would want to use spring-boot-resources/library compared to using BuildProperties-based service name / service version detectors?

We currently are not publishing these in a separate jar, the only way to get them is to use the autoconfigure module. I do agree that spring-boot-resources has limited usage outside the agent.

[trask]

We currently are not publishing these in a separate jar, the only way to get them is to use the autoconfigure module. I do agree that spring-boot-resources has limited usage outside the agent.

@zeitlinger if you and @jeanbisutti agree, I'd suggest that we rename spring-boot-resources/library to spring-boot-resources/javaagent, and if someone wants to use the BuildProperties-based service name / service version detectors outside of the autoconfigure module, we can add a new spring-boot-resources/library module in the future to contain those

[zeitlinger]

rename spring-boot-resources/library to spring-boot-resources/javaagent

created #10715