-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest resource detector #10621
Merged
trask
merged 14 commits into
open-telemetry:main
from
zeitlinger:manifest-resource-detector
Mar 13, 2024
Merged
Manifest resource detector #10621
trask
merged 14 commits into
open-telemetry:main
from
zeitlinger:manifest-resource-detector
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
force-pushed
the
manifest-resource-detector
branch
from
February 21, 2024 14:45
e4b6ca0
to
b372f09
Compare
zeitlinger
force-pushed
the
manifest-resource-detector
branch
2 times, most recently
from
February 22, 2024 11:39
73ba3c3
to
b40416b
Compare
jeanbisutti
reviewed
Feb 22, 2024
...ntelemetry/instrumentation/spring/autoconfigure/resources/OtelResourceAutoConfiguration.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Feb 22, 2024
...brary/src/main/java/io/opentelemetry/instrumentation/resources/ManifestResourceProvider.java
Outdated
Show resolved
Hide resolved
zeitlinger
force-pushed
the
manifest-resource-detector
branch
from
February 23, 2024 15:13
da5bbdb
to
10f0e36
Compare
jeanbisutti
added
the
test native
This label can be applied to PRs to trigger them to run native tests
label
Mar 1, 2024
zeitlinger
force-pushed
the
manifest-resource-detector
branch
from
March 1, 2024 11:39
10f0e36
to
8f84013
Compare
jeanbisutti
reviewed
Mar 5, 2024
...rces/library/src/main/java/io/opentelemetry/instrumentation/resources/AttributeProvider.java
Outdated
Show resolved
Hide resolved
...ources/library/src/main/java/io/opentelemetry/instrumentation/resources/JarFileDetector.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/ResourceDiscoveryCache.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/ResourceDiscoveryCache.java
Outdated
Show resolved
Hide resolved
zeitlinger
force-pushed
the
manifest-resource-detector
branch
from
March 11, 2024 15:38
7368dc9
to
2672296
Compare
jeanbisutti
reviewed
Mar 12, 2024
...esources/library/src/main/java/io/opentelemetry/instrumentation/resources/JarPathFinder.java
Outdated
Show resolved
Hide resolved
zeitlinger
force-pushed
the
manifest-resource-detector
branch
from
March 12, 2024 12:20
2672296
to
acf1dcf
Compare
trask
reviewed
Mar 12, 2024
zeitlinger
force-pushed
the
manifest-resource-detector
branch
from
March 12, 2024 15:05
acf1dcf
to
4eb9368
Compare
jeanbisutti
approved these changes
Mar 12, 2024
zeitlinger
force-pushed
the
manifest-resource-detector
branch
from
March 13, 2024 14:54
4eb9368
to
9cc81e1
Compare
trask
reviewed
Mar 13, 2024
...brary/src/main/java/io/opentelemetry/instrumentation/resources/ManifestResourceProvider.java
Outdated
Show resolved
Hide resolved
…ry/instrumentation/resources/ManifestResourceProvider.java Co-authored-by: Trask Stalnaker <[email protected]>
trask
reviewed
Mar 13, 2024
...library/src/main/java/io/opentelemetry/instrumentation/resources/JarServiceNameDetector.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Mar 14, 2024
...rary/src/main/java/io/opentelemetry/instrumentation/resources/AttributeResourceProvider.java
Show resolved
Hide resolved
laurit
reviewed
Mar 14, 2024
...esources/library/src/main/java/io/opentelemetry/instrumentation/resources/JarPathFinder.java
Show resolved
Hide resolved
laurit
reviewed
Mar 14, 2024
...brary/src/main/java/io/opentelemetry/instrumentation/resources/ManifestResourceProvider.java
Show resolved
Hide resolved
laurit
reviewed
Mar 14, 2024
...brary/src/main/java/io/opentelemetry/instrumentation/resources/ManifestResourceProvider.java
Show resolved
Hide resolved
laurit
reviewed
Mar 14, 2024
...rary/src/main/java/io/opentelemetry/instrumentation/resources/AttributeResourceProvider.java
Show resolved
Hide resolved
@laurit thanks for the review - please have a look now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10615