-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MyBatis framework #10258
Conversation
.../javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/mybatis/MybatisTest.java
Outdated
Show resolved
Hide resolved
.../javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/mybatis/MybatisTest.java
Outdated
Show resolved
Hide resolved
.../javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/mybatis/MybatisTest.java
Outdated
Show resolved
Hide resolved
.../javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/mybatis/MybatisTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One CI failure is that a method has to be static:
MybatisTest.java:61: warning: [MethodCanBeStatic] A private method that does not reference the enclosing instance can be static
private void span(String spanName) {
ok, thanks, I solved it now. |
...nt/src/main/java/io/opentelemetry/javaagent/instrumentation/mybatis/MapperMethodRequest.java
Outdated
Show resolved
Hide resolved
...main/java/io/opentelemetry/javaagent/instrumentation/mybatis/MybatisAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...gent/src/main/java/io/opentelemetry/javaagent/instrumentation/mybatis/MybatisSingletons.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/opentelemetry/javaagent/instrumentation/mybatis/MybatisSpanNameExtractor.java
Outdated
Show resolved
Hide resolved
.../javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/mybatis/MybatisTest.java
Outdated
Show resolved
Hide resolved
.../javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/mybatis/MybatisTest.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/javaagent/instrumentation/mybatis/MybatisInstrumentationModule.java
Outdated
Show resolved
Hide resolved
.../javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/mybatis/MybatisTest.java
Outdated
Show resolved
Hide resolved
The span added this time without any additional attributes, just to show the span? |
Yes, at present, no particularly valuable attributes have been found that need to be added. |
...agent/src/test/java/io/opentelemetry/javaagent/instrumentation/mybatis/v3_2/MyBatisTest.java
Outdated
Show resolved
Hide resolved
...agent/src/test/java/io/opentelemetry/javaagent/instrumentation/mybatis/v3_2/MyBatisTest.java
Outdated
Show resolved
Hide resolved
...agent/src/test/java/io/opentelemetry/javaagent/instrumentation/mybatis/v3_2/MyBatisTest.java
Outdated
Show resolved
Hide resolved
...agent/src/test/java/io/opentelemetry/javaagent/instrumentation/mybatis/v3_2/MyBatisTest.java
Outdated
Show resolved
Hide resolved
Hi @laurit @jeanbisutti, for the PR, do you have any more suggestions? |
@laurit what do you think of making this instrumentation opt-in since it doesn't implement any semconv? |
@steverao I create a PR (steverao#1) for your PR that should get this closer to mergeable shape. In this PR
|
Thank you very much for your optimization. I think there is no problem with the other points. The instrumentation is set to disabled by default. mainly to consider that sometimes it may not be much different from the database, right? |
Co-authored-by: Lauri Tulmin <[email protected]>
Add support for
MyBatis
framework, for detail can see #10186Resolves #10186