New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Timer class to instrumentation-api #4514

Closed

trask opened this issue Oct 27, 2021 · 1 comment · Fixed by #8009

Labels

Member

trask commented Oct 27, 2021

We have 4 copies of this class in different instrumentations. Does it make sense to introduce into the instrumentation-api?

trask added the enhancement label

trask mentioned this issue

Convert RabbitMQ to Instrumenter #4463

Merged

Contributor

iNikem commented Oct 27, 2021

I am not quite sure why is it needed :) So javadoc explaining reasons of its existing is also required.

mateuszrzeszutek mentioned this issue

Instrumentation API changes: TimeExtractor with Context idea #6024

Closed

laurit mentioned this issue

Share timer class used by messaging instrumentations #8009

Merged

laurit closed this as completed in #8009

laurit added a commit that referenced this issue


          Share timer class used by messaging instrumentations (#8009)

f1411d1

Resolves
#4514
There is also a slightly different timer class in netty instrumentation
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/netty/netty-common/library/src/main/java/io/opentelemetry/instrumentation/netty/common/internal/Timer.java
that I didn't touch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment