Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect values for client span's Status #418

Closed
iNikem opened this issue May 19, 2020 · 3 comments
Closed

Incorrect values for client span's Status #418

iNikem opened this issue May 19, 2020 · 3 comments

Comments

@iNikem
Copy link
Contributor

iNikem commented May 19, 2020

io.opentelemetry.auto.bootstrap.instrumentation.decorator.HttpClientDecorator#onResponse currently sets client span status to either OK or UNKNOWN. One would expect that e.g. http status 404 will result in span status NOT_FOUND. Also 400 probably means INVALID_ARGUMENT etc.

I remember I saw somewhere some discussion about how http statuses should map to span statuses, but cannot find it at the moment.

@trask
Copy link
Member

trask commented May 20, 2020

Probably a duplicate of #326?

@iNikem
Copy link
Contributor Author

iNikem commented May 20, 2020

@trask indeed, this is a duplicate.

@iNikem iNikem closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants