Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to map HTTP and gRPC status codes to Span.setStatus() #326

Closed
trask opened this issue Apr 15, 2020 · 7 comments
Closed

Need to map HTTP and gRPC status codes to Span.setStatus() #326

trask opened this issue Apr 15, 2020 · 7 comments
Assignees

Comments

@jkwatson
Copy link
Contributor

Seems like a good chance to do an audit of those mappings and make sure they make sense, as well. Not sure if anyone has actually used them yet. ;)

@trask trask added good first issue Good for newcomers contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome labels Apr 23, 2020
@trask trask removed the good first issue Good for newcomers label May 6, 2020
@iNikem
Copy link
Contributor

iNikem commented May 20, 2020

If this task is about implementing the straightforward mapping described in spec doc, then I can take it. I don't quite understand what did @jkwatson mean by audit though :)

@trask
Copy link
Member Author

trask commented May 20, 2020

all yours 😄

@jkwatson
Copy link
Contributor

I was just suggesting that if we run across a status that doesn't map well, that would be important feedback for the specs.

@trask trask added specification and removed contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome labels May 27, 2020
@trask
Copy link
Member Author

trask commented Jul 16, 2020

Hoping we can close this soon if span status goes away open-telemetry/oteps#123 (comment)

@anuraaga
Copy link
Contributor

Technically we could probably close anyways I added that mapping a while ago I think.

@trask trask assigned anuraaga and unassigned iNikem Jul 16, 2020
@trask
Copy link
Member Author

trask commented Jul 16, 2020

Then closing!

@trask trask closed this as completed Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants