Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context loss during .yieldAll call in ratpack #3390

Closed
necrolyte2 opened this issue Jun 23, 2021 · 0 comments · Fixed by #3416
Closed

Context loss during .yieldAll call in ratpack #3390

necrolyte2 opened this issue Jun 23, 2021 · 0 comments · Fixed by #3416
Labels
bug Something isn't working

Comments

@necrolyte2
Copy link

Describe the bug
Very similar to #3358, however, this time the context is lost during a .yieldAll call.
Interestingly, .yield seems to work

Steps to reproduce
Run the following code and look at the traces in the Jaeger UI
https://github.com/necrolyte2/ratpack-kotlin-otel/releases/tag/3.0.0

What did you expect to see?
Single trace with all spans nested under it

What did you see instead?
One trace for the incoming http request to the ratpack application
One trace per outgoing http call

What version are you using?
1.4.0-SNAPSHOT(built from #3371)

Environment
Compiler: AdoptOpenJDK 11.0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Context propagation for ratpack Execution.fork() laurit/opentelemetry-java-instrumentation
1 participant
@necrolyte2