Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context propegation lost over CompletableFuture/Promise.async #3358

Closed
necrolyte2 opened this issue Jun 18, 2021 · 0 comments · Fixed by #3371
Closed

Context propegation lost over CompletableFuture/Promise.async #3358

necrolyte2 opened this issue Jun 18, 2021 · 0 comments · Fixed by #3371
Labels
bug Something isn't working repro provided

Comments

@necrolyte2
Copy link

Describe the bug
It seems that context is being lost if there is a CompletableFuture or a Promise.async wrapped around a CompletableFuture

Steps to reproduce
Run the following project
https://github.com/necrolyte2/ratpack-kotlin-otel/releases/tag/2.0.1

docker-compose up
for ep in http onlyhttp onlycassandra cassandrahttp; do curl http://localhost:5050/api/v1/${ep}/1; done

View the traces in the jaeger ui at http://localhost:16868

What did you expect to see?
There should be a single trace that contains all of the spans for this single endpoint call

What did you see instead?
Each http call is generating its own trace instead of using the parent trace id

What version are you using?
All OTEL versions seem to have this issue

Environment
Compiler: AdoptOpenJDK 11.x

Additional context
Screenshots are included in the tagged release page
https://github.com/necrolyte2/ratpack-kotlin-otel/releases/tag/2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working repro provided
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants