add missing @nullable

open-telemetry · Apr 28, 2021 · c729d58 · c729d58
1 parent add8b83
commit c729d58
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/...lemetry/instrumentation/api/instrumenter/net/InetSocketAddressNetAttributesExtractor.java b/...lemetry/instrumentation/api/instrumenter/net/InetSocketAddressNetAttributesExtractor.java
@@ -29,7 +29,7 @@ public abstract class InetSocketAddressNetAttributesExtractor<REQUEST, RESPONSE>
 
   @Override
   @Nullable
-  protected final String peerName(REQUEST request, RESPONSE response) {
+  protected final String peerName(REQUEST request, @Nullable RESPONSE response) {
     InetSocketAddress address = getAddress(request, response);
     if (address == null) {
       return null;
@@ -42,7 +42,7 @@ protected final String peerName(REQUEST request, RESPONSE response) {
 
   @Override
   @Nullable
-  protected final Long peerPort(REQUEST request, RESPONSE response) {
+  protected final Long peerPort(REQUEST request, @Nullable RESPONSE response) {
     InetSocketAddress address = getAddress(request, response);
     if (address == null) {
       return null;
@@ -52,7 +52,7 @@ protected final Long peerPort(REQUEST request, RESPONSE response) {
 
   @Override
   @Nullable
-  protected final String peerIp(REQUEST request, RESPONSE response) {
+  protected final String peerIp(REQUEST request, @Nullable RESPONSE response) {
     InetSocketAddress address = getAddress(request, response);
     if (address == null) {
       return null;

diff --git a/...ain/java/io/opentelemetry/instrumentation/armeria/v1_3/ArmeriaNetAttributesExtractor.java b/...ain/java/io/opentelemetry/instrumentation/armeria/v1_3/ArmeriaNetAttributesExtractor.java
@@ -23,7 +23,8 @@ protected String transport(RequestContext requestContext) {
 
   @Override
   @Nullable
-  protected InetSocketAddress getAddress(RequestContext requestContext, RequestLog requestLog) {
+  protected InetSocketAddress getAddress(
+      RequestContext requestContext, @Nullable RequestLog requestLog) {
     SocketAddress address = requestContext.remoteAddress();
     if (address instanceof InetSocketAddress) {
       return (InetSocketAddress) address;