7883 ClassCastException when using -Dotel.jmx.target.system=tomcat (#…

…7884) Using "1" to specify units of plain cardinality.
open-telemetry · Feb 23, 2023 · 98653ef · 98653ef
1 parent 7062ee4
commit 98653ef
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/instrumentation/jmx-metrics/javaagent/src/main/resources/jmx/rules/hadoop.yaml b/instrumentation/jmx-metrics/javaagent/src/main/resources/jmx/rules/hadoop.yaml
@@ -1,7 +1,7 @@
 ---
 rules:
  - bean: Hadoop:service=NameNode,name=FSNamesystem
-   unit: 1
+   unit: "1"
    prefix: hadoop.
    metricAttribute:
      node_name: param(tag.Hostname)

diff --git a/instrumentation/jmx-metrics/javaagent/src/main/resources/jmx/rules/jetty.yaml b/instrumentation/jmx-metrics/javaagent/src/main/resources/jmx/rules/jetty.yaml
@@ -44,13 +44,13 @@ rules:
     mapping:
       selectCount:
         type: counter
-        unit: 1
+        unit: "1"
         desc: The number of select calls
 
   - bean: org.eclipse.jetty.logging:type=jettyloggerfactory,id=*
     prefix: jetty.logging.
     mapping:
       LoggerCount:
         type: updowncounter
-        unit: 1
+        unit: "1"
         desc: The number of registered loggers by name
diff --git a/instrumentation/jmx-metrics/javaagent/src/main/resources/jmx/rules/tomcat.yaml b/instrumentation/jmx-metrics/javaagent/src/main/resources/jmx/rules/tomcat.yaml
@@ -1,7 +1,7 @@
 ---
 rules:
  - bean: Catalina:type=GlobalRequestProcessor,name=*
-   unit: 1
+   unit: "1"
    prefix: http.server.tomcat.
    metricAttribute:
      name: param(name)
@@ -39,7 +39,7 @@ rules:
        metricAttribute:
          direction: const(sent)
  - bean: Catalina:type=Manager,host=localhost,context=*
-   unit: 1
+   unit: "1"
    prefix: http.server.tomcat.
    type: updowncounter
    metricAttribute:

diff --git a/instrumentation/jmx-metrics/javaagent/src/main/resources/jmx/rules/wildfly.yaml b/instrumentation/jmx-metrics/javaagent/src/main/resources/jmx/rules/wildfly.yaml
@@ -5,7 +5,7 @@ rules:
      deployment: param(deployment)
    prefix: wildfly.session.
    type: counter
-   unit: 1
+   unit: "1"
    mapping:
      sessionsCreated:
      activeSessions:
@@ -18,7 +18,7 @@ rules:
      listener: param(http-listener)
    prefix: wildfly.request.
    type: counter
-   unit: 1
+   unit: "1"
    mapping:
      requestCount:
      processingTime:
@@ -42,7 +42,7 @@ rules:
        metricAttribute:
          direction: const(in)
  - bean: jboss.as:subsystem=datasources,data-source=*,statistics=pool
-   unit: 1
+   unit: "1"
    metricAttribute:
      data_source: param(data-source)
    mapping: