use DefaultHttpServerInstrumenterBuilder to configure spring starter

open-telemetry · Jun 27, 2024 · 90b7170 · 90b7170
1 parent 25e510f
commit 90b7170
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/smoke-tests-otel-starter/spring-boot-reactive-common/src/main/resources/application.yaml b/smoke-tests-otel-starter/spring-boot-reactive-common/src/main/resources/application.yaml
@@ -3,6 +3,11 @@ otel:
     common:
       db-statement-sanitizer:
         enabled: false
+    http:
+      client:
+        emit-experimental-telemetry: true
+      server:
+        emit-experimental-telemetry: true
 
 spring:
   r2dbc:

diff --git a/.../spring-smoke-testing/src/main/java/io/opentelemetry/spring/smoketest/SpringTestUtil.java b/.../spring-smoke-testing/src/main/java/io/opentelemetry/spring/smoketest/SpringTestUtil.java
@@ -26,7 +26,7 @@ public static void assertClientSpan(SpanDataAssert span, String path) {
         .hasAttributesSatisfying(
             OpenTelemetryAssertions.satisfies(UrlAttributes.URL_FULL, a -> a.endsWith(path)),
             // this attribute is set by the experimental http instrumentation
-            OpenTelemetryAssertions.satisfies(BODY_SIZE, AbstractLongAssert::isPositive));
+            OpenTelemetryAssertions.satisfies(BODY_SIZE, AbstractLongAssert::isNotNegative));
   }
 
   @CanIgnoreReturnValue
@@ -37,7 +37,7 @@ public static SpanDataAssert assertServerSpan(SpanDataAssert span, String route)
         .hasAttribute(HttpAttributes.HTTP_ROUTE, route)
         .hasAttributesSatisfying(
             // this attribute is set by the experimental http instrumentation
-            OpenTelemetryAssertions.satisfies(BODY_SIZE, AbstractLongAssert::isPositive));
+            OpenTelemetryAssertions.satisfies(BODY_SIZE, AbstractLongAssert::isNotNegative));
     return span;
   }
 }