polish code

open-telemetry · May 8, 2024 · 869c565 · 869c565
1 parent f3f2fad
commit 869c565
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/instrumentation/apache-shenyu/apache-shenyu-2.4/javaagent/build.gradle.kts b/instrumentation/apache-shenyu/apache-shenyu-2.4/javaagent/build.gradle.kts
@@ -7,6 +7,7 @@ muzzle {
     group.set("org.apache.shenyu")
     module.set("shenyu-web")
     versions.set("[2.4.0,)")
+    assertInverse.set(true)
   }
 }
 
@@ -15,7 +16,6 @@ dependencies {
   compileOnly("com.google.auto.value:auto-value-annotations")
   annotationProcessor("com.google.auto.value:auto-value")
 
-  testInstrumentation(project(":instrumentation:apache-shenyu:apache-shenyu-2.4:javaagent"))
   testInstrumentation(project(":instrumentation:netty:netty-4.1:javaagent"))
   testInstrumentation(project(":instrumentation:reactor:reactor-3.1:javaagent"))
   testInstrumentation(project(":instrumentation:reactor:reactor-netty:reactor-netty-1.0:javaagent"))
@@ -25,7 +25,7 @@ dependencies {
   testImplementation("org.springframework.boot:spring-boot-starter-webflux:2.2.2.RELEASE") {
     exclude("org.codehaus.groovy", "groovy")
   }
-//  based on apache shenyu 2.4.0 official example
+  // based on apache shenyu 2.4.0 official example
   testImplementation("org.apache.shenyu:shenyu-spring-boot-starter-gateway:2.4.0") {
     exclude("org.codehaus.groovy", "groovy")
   }

diff --git a/..._4/ApacheShenyuInstrumentationModule.java → ..._4/ApacheShenYuInstrumentationModule.java b/..._4/ApacheShenyuInstrumentationModule.java → ..._4/ApacheShenYuInstrumentationModule.java
@@ -13,8 +13,8 @@
 import java.util.List;
 
 @AutoService(InstrumentationModule.class)
-public class ApacheShenyuInstrumentationModule extends InstrumentationModule {
-  public ApacheShenyuInstrumentationModule() {
+public class ApacheShenYuInstrumentationModule extends InstrumentationModule {
+  public ApacheShenYuInstrumentationModule() {
     super("apache-shenyu", "apache-shenyu-2.4");
   }
 

diff --git a/...heshenyu/v2_4/ApacheShenyuSingletons.java → ...heshenyu/v2_4/ApacheShenYuSingletons.java b/...heshenyu/v2_4/ApacheShenyuSingletons.java → ...heshenyu/v2_4/ApacheShenYuSingletons.java
@@ -8,9 +8,9 @@
 import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRouteGetter;
 import org.apache.shenyu.common.dto.MetaData;
 
-public class ApacheShenyuSingletons {
+public final class ApacheShenYuSingletons {
 
-  private ApacheShenyuSingletons() {}
+  private ApacheShenYuSingletons() {}
 
   public static HttpServerRouteGetter<MetaData> httpRouteGetter() {
     return (context, metaData) -> metaData.getPath();

diff --git a/...ntelemetry/javaagent/instrumentation/apacheshenyu/v2_4/ContextBuilderInstrumentation.java b/...ntelemetry/javaagent/instrumentation/apacheshenyu/v2_4/ContextBuilderInstrumentation.java
@@ -48,7 +48,7 @@ public static void onExit(@Advice.Argument(0) ServerWebExchange exchange) {
       HttpServerRoute.update(
           context,
           HttpServerRouteSource.NESTED_CONTROLLER,
-          ApacheShenyuSingletons.httpRouteGetter(),
+          ApacheShenYuSingletons.httpRouteGetter(),
           metaData);
       MetaDataHelper.extractAttributes(metaData, context);
     }

diff --git a/...on/apacheshenyu/v2_4/ShenyuRouteTest.java → ...on/apacheshenyu/v2_4/ShenYuRouteTest.java b/...on/apacheshenyu/v2_4/ShenyuRouteTest.java → ...on/apacheshenyu/v2_4/ShenYuRouteTest.java
@@ -30,8 +30,8 @@
 @SpringBootTest(
     properties = {"shenyu.local.enabled=true", "spring.main.allow-bean-definition-overriding=true"},
     webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT,
-    classes = {ShenyuBootstrapApplication.class, ShenyuRouteTest.ForceNettyAutoConfiguration.class})
-public class ShenyuRouteTest {
+    classes = {ShenyuBootstrapApplication.class, ShenYuRouteTest.ForceNettyAutoConfiguration.class})
+class ShenYuRouteTest {
 
   private static final AttributeKey<String> META_ID_ATTRIBUTE =
       AttributeKey.stringKey("apache-shenyu.meta.id");
@@ -75,7 +75,7 @@ NettyReactiveWebServerFactory nettyFactory() {
   }
 
   @RegisterExtension
-  static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
+  private static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
 
   final ConfigurableApplicationContext[] context = {null};