code review comments -- renaming for consistency

open-telemetry · Jan 14, 2022 · 781fffb · 781fffb
1 parent 0a7ebd5
commit 781fffb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...java/io/opentelemetry/instrumentation/api/instrumenter/net/NetClientAttributesGetter.java b/...java/io/opentelemetry/instrumentation/api/instrumenter/net/NetClientAttributesGetter.java
@@ -12,7 +12,7 @@
  * response into the 4 common network attribute values.
  *
  * <p>Instrumentation authors will create implementations of this interface for their specific
- * library/framework. It will be used by the NetworkClientAttributesExtractor to obtain the various
+ * library/framework. It will be used by the NetClientAttributesExtractor to obtain the various
  * network attributes in a type-generic way.
  */
 public interface NetClientAttributesGetter<REQUEST, RESPONSE> {

diff --git a/...entelemetry/javaagent/instrumentation/asynchttpclient/v2_0/AsyncHttpClientSingletons.java b/...entelemetry/javaagent/instrumentation/asynchttpclient/v2_0/AsyncHttpClientSingletons.java
@@ -29,18 +29,18 @@ public final class AsyncHttpClientSingletons {
         HttpSpanNameExtractor.create(httpAttributesExtractor);
     SpanStatusExtractor<RequestContext, Response> spanStatusExtractor =
         HttpSpanStatusExtractor.create(httpAttributesExtractor);
-    AsyncHttpClientNetAttributesGetter netAttributeAdapter =
+    AsyncHttpClientNetAttributesGetter netAttributeGetter =
         new AsyncHttpClientNetAttributesGetter();
     NetClientAttributesExtractor<RequestContext, Response> netAttributesExtractor =
-        NetClientAttributesExtractor.create(netAttributeAdapter);
+        NetClientAttributesExtractor.create(netAttributeGetter);
 
     INSTRUMENTER =
         Instrumenter.<RequestContext, Response>builder(
                 GlobalOpenTelemetry.get(), INSTRUMENTATION_NAME, spanNameExtractor)
             .setSpanStatusExtractor(spanStatusExtractor)
             .addAttributesExtractor(httpAttributesExtractor)
             .addAttributesExtractor(netAttributesExtractor)
-            .addAttributesExtractor(PeerServiceAttributesExtractor.create(netAttributeAdapter))
+            .addAttributesExtractor(PeerServiceAttributesExtractor.create(netAttributeGetter))
             .addAttributesExtractor(new AsyncHttpClientAdditionalAttributesExtractor())
             .addRequestMetrics(HttpClientMetrics.get())
             .newClientInstrumenter(HttpHeaderSetter.INSTANCE);