Additional http.status_code assertion (#4872)

open-telemetry · Dec 13, 2021 · 6d254b3 · 6d254b3
1 parent 9896cab
commit 6d254b3
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/...main/java/io/opentelemetry/instrumentation/testing/junit/http/AbstractHttpClientTest.java b/...main/java/io/opentelemetry/instrumentation/testing/junit/http/AbstractHttpClientTest.java
@@ -969,6 +969,9 @@ SpanDataAssert assertClientSpan(
               if (responseCode != null) {
                 assertThat(attrs)
                     .containsEntry(SemanticAttributes.HTTP_STATUS_CODE, (long) responseCode);
+              } else {
+                // worth adding AttributesAssert.doesNotContainKey?
+                assertThat(attrs.get(SemanticAttributes.HTTP_STATUS_CODE)).isNull();
               }
             });
   }