pr review

open-telemetry · Jul 10, 2024 · 5bf055a · 5bf055a
1 parent 590a611
commit 5bf055a
Showing 1 changed file with 1 addition and 12 deletions.
diff --git a/.../instrumentation/api/incubator/builder/internal/DefaultHttpServerInstrumenterBuilder.java b/.../instrumentation/api/incubator/builder/internal/DefaultHttpServerInstrumenterBuilder.java
@@ -169,22 +169,15 @@ public DefaultHttpServerInstrumenterBuilder<REQUEST, RESPONSE> setSpanNameExtrac
   }
 
   public Instrumenter<REQUEST, RESPONSE> build() {
-    return build(b -> {});
-  }
-
-  public Instrumenter<REQUEST, RESPONSE> build(
-      Consumer<InstrumenterBuilder<REQUEST, RESPONSE>> instrumenterBuilderConsumer) {
-
     InstrumenterBuilder<REQUEST, RESPONSE> builder = builder();
-    instrumenterBuilderConsumer.accept(builder);
 
     if (headerGetter != null) {
       return builder.buildServerInstrumenter(headerGetter);
     }
     return builder.buildInstrumenter(SpanKindExtractor.alwaysServer());
   }
 
-  public InstrumenterBuilder<REQUEST, RESPONSE> builder() {
+  private InstrumenterBuilder<REQUEST, RESPONSE> builder() {
     SpanNameExtractor<? super REQUEST> spanNameExtractor =
         spanNameExtractorTransformer.apply(httpSpanNameExtractorBuilder.build());
 
@@ -206,10 +199,6 @@ public InstrumenterBuilder<REQUEST, RESPONSE> builder() {
     return builder;
   }
 
-  public OpenTelemetry getOpenTelemetry() {
-    return openTelemetry;
-  }
-
   @CanIgnoreReturnValue
   public DefaultHttpServerInstrumenterBuilder<REQUEST, RESPONSE> configure(CommonConfig config) {
     set(config::getKnownHttpRequestMethods, this::setKnownMethods);