Use more @ConditionalOnEnabledInstrumentation (#11665)

open-telemetry · Jun 25, 2024 · 4d6b1cd · 4d6b1cd
1 parent ec02fb5
commit 4d6b1cd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/...ring/autoconfigure/instrumentation/mongo/MongoClientInstrumentationAutoConfiguration.java b/...ring/autoconfigure/instrumentation/mongo/MongoClientInstrumentationAutoConfiguration.java
@@ -8,21 +8,18 @@
 import com.mongodb.MongoClientSettings;
 import io.opentelemetry.api.OpenTelemetry;
 import io.opentelemetry.instrumentation.mongo.v3_1.MongoTelemetry;
+import io.opentelemetry.instrumentation.spring.autoconfigure.internal.ConditionalOnEnabledInstrumentation;
 import io.opentelemetry.instrumentation.spring.autoconfigure.internal.InstrumentationConfigUtil;
-import io.opentelemetry.instrumentation.spring.autoconfigure.internal.SdkEnabled;
 import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
 import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
 import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
-import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
 import org.springframework.boot.autoconfigure.mongo.MongoClientSettingsBuilderCustomizer;
 import org.springframework.context.annotation.Bean;
-import org.springframework.context.annotation.Conditional;
 import org.springframework.context.annotation.Configuration;
 
 @ConditionalOnBean(OpenTelemetry.class)
 @ConditionalOnClass(MongoClientSettings.class)
-@ConditionalOnProperty(name = "otel.instrumentation.mongo.enabled", matchIfMissing = true)
-@Conditional(SdkEnabled.class)
+@ConditionalOnEnabledInstrumentation(module = "mongo")
 @Configuration
 public class MongoClientInstrumentationAutoConfiguration {
 

diff --git a/...ion/spring/autoconfigure/instrumentation/r2dbc/R2dbcInstrumentationAutoConfiguration.java b/...ion/spring/autoconfigure/instrumentation/r2dbc/R2dbcInstrumentationAutoConfiguration.java
@@ -6,21 +6,18 @@
 package io.opentelemetry.instrumentation.spring.autoconfigure.instrumentation.r2dbc;
 
 import io.opentelemetry.api.OpenTelemetry;
-import io.opentelemetry.instrumentation.spring.autoconfigure.internal.SdkEnabled;
+import io.opentelemetry.instrumentation.spring.autoconfigure.internal.ConditionalOnEnabledInstrumentation;
 import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
 import io.r2dbc.spi.ConnectionFactory;
 import org.springframework.beans.factory.ObjectProvider;
 import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
 import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
-import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
 import org.springframework.context.annotation.Bean;
-import org.springframework.context.annotation.Conditional;
 import org.springframework.context.annotation.Configuration;
 
 @ConditionalOnBean(OpenTelemetry.class)
 @ConditionalOnClass(ConnectionFactory.class)
-@ConditionalOnProperty(name = "otel.instrumentation.r2dbc.enabled", matchIfMissing = true)
-@Conditional(SdkEnabled.class)
+@ConditionalOnEnabledInstrumentation(module = "r2dbc")
 @Configuration(proxyBeanMethods = false)
 public class R2dbcInstrumentationAutoConfiguration {