Add comment to JDBC DataSource instrumentation (#2940)

open-telemetry · May 11, 2021 · 1086bce · 1086bce
1 parent 871f9a0
commit 1086bce
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/.../io/opentelemetry/javaagent/instrumentation/jdbc/JdbcDataSourceInstrumentationModule.java b/.../io/opentelemetry/javaagent/instrumentation/jdbc/JdbcDataSourceInstrumentationModule.java
@@ -61,9 +61,9 @@ public static void start(
         @Advice.This DataSource ds,
         @Advice.Local("otelContext") Context context,
         @Advice.Local("otelScope") Scope scope) {
-      // TODO this is very strange condition
       if (!Java8BytecodeBridge.currentSpan().getSpanContext().isValid()) {
-        // Don't want to generate a new top-level span
+        // this instrumentation is already very noisy, and calls to getConnection outside of an
+        // existing trace do not tend to be very interesting
         return;
       }