Activemq #188
Activemq #188
Conversation
| @@ -0,0 +1,79 @@ | |||
| # ActiveMQ Metrics | |||
|
|
|||
| The JMX Metric Gatherer provides built in Tomcat metric gathering capabilities. | |||
There was a problem hiding this comment.
Update this to say ActiveMQ
| The JMX Metric Gatherer provides built in Tomcat metric gathering capabilities. | |
| The JMX Metric Gatherer provides built in ActiveMQ metric gathering capabilities. |
|
hi @armstrmi! can you fetch |
| * Description: The number of consumers currently reading from the broker. | ||
| * Unit: `{consumers}` | ||
| * Labels: `destination` | ||
| * Instrument Type: LongUpDownCounterCallback |
There was a problem hiding this comment.
We need to standardize these names throughout our docs, but should these be something like ObservableLongUpDownCounter? I'm not sure where the spec has landed.
There was a problem hiding this comment.
I'm curious about this one, can't seem to find any reference to how we should be naming it, personally, to me, it seems to make sense to match what's actually being used in the script. Is there a reason we're adding "observable"? just wasn't sure about this one. Thanks for any clarification!
There was a problem hiding this comment.
https://github.com/open-telemetry/opentelemetry-specification/blob/5d374f8045dcb24523f5f17a4b8ba94542fd0b70/specification/metrics/api.md#asynchronous-counter and the java api uses "Observable" for its measurement interfaces.
jmx-metrics/src/test/java/io/opentelemetry/contrib/jmxmetrics/JmxConfigTest.java
Outdated
Show resolved
Hide resolved
| * Instrument Type: LongCounterCallback | ||
|
|
||
|
|
||
| * Name: `activemq.wait_time.avg` |
There was a problem hiding this comment.
looks like this name is wrong compared to the script activemq.message.wait_time.avg
There was a problem hiding this comment.
LGTM
@rmfitzpatrick I believe all of your feedback has been addressed as well
|
@rmfitzpatrick could you please take a look at this when you get the chance |
Thanks for the addition! |
Description:
Existing Issue(s):
Testing:
Added integration tests for activemq metrics
Documentation: