Update semconv dependency version #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
trask
force-pushed
the
update-semconv-dependency-version
branch
from
f84e678 to
05f5fbe
Compare
laurit
reviewed
Dec 10, 2024
| import static io.opentelemetry.semconv.trace.attributes.SemanticAttributes.RPC_METHOD; | ||
| import static io.opentelemetry.semconv.trace.attributes.SemanticAttributes.RPC_SERVICE; | ||
| import static io.opentelemetry.semconv.ServiceAttributes.SERVICE_NAME; | ||
| import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_OPERATION; |
There was a problem hiding this comment.
Is using incubating attributes here ok?
There was a problem hiding this comment.
we may be able to revise our guidance about inlining incubating attributes now that we are planning to keep them around @jack-berg?
it's definitely nice to not inline them, since then we get the deprecation warnings and know when we need to consider making semconv updates
There was a problem hiding this comment.
@laurit I think it's a good question, but I'd suggest it's ok to merge this PR as-is since it's not introducing any new problems
There was a problem hiding this comment.
I think incubating attributes should be fine.
breedx-splk
approved these changes
Dec 11, 2024
| import static io.opentelemetry.semconv.trace.attributes.SemanticAttributes.RPC_METHOD; | ||
| import static io.opentelemetry.semconv.trace.attributes.SemanticAttributes.RPC_SERVICE; | ||
| import static io.opentelemetry.semconv.ServiceAttributes.SERVICE_NAME; | ||
| import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_OPERATION; |
There was a problem hiding this comment.
I think incubating attributes should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates semconv dependency version without making any changes to the underlying telemetry.