[baggage-processor] Add BaggageLogRecordProcessor #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrille-leclerc
commented
Nov 28, 2024
...src/test/java/io/opentelemetry/contrib/baggage/processor/BaggageProcessorCustomizerTest.java
Outdated
Show resolved
Hide resolved
…r-log-testing add simple log test
cyrille-leclerc
changed the title
cyrille-leclerc
commented
Nov 28, 2024
...src/test/java/io/opentelemetry/contrib/baggage/processor/BaggageProcessorCustomizerTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/io/opentelemetry/contrib/baggage/processor/BaggageProcessorCustomizerTest.java
Outdated
Show resolved
Hide resolved
zeitlinger
reviewed
Nov 29, 2024
| } | ||
|
|
||
| static BaggageSpanProcessor createBaggageSpanProcessor(List<String> keys) { | ||
| if (keys.size() == 1 && keys.get(0).equals("*")) { |
There was a problem hiding this comment.
nit: extract isWildcard method to be reused for logger
Co-authored-by: Gregor Zeitlinger <[email protected]>
zeitlinger
approved these changes
Nov 29, 2024
trask
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Support promoting Baggage attributes as log attributes the same we we can promote baggage attributes as span attributes.
Existing Issue(s):
BaggageLogRecordProcessorfor parity with theBaggageSpanProcessor#1577Testing:
Enriched the
BaggageProcessorCustomizerTestwith tests for log entries.Documentation:
README.md updated
Outstanding items:
We can enrich metrics with Baggage attributes the same way we enrich spans and logs because there is no equivalent for metrics to the Span Processor API and the Log Record PRocessor API in OTel SDK specifications.