Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename param and description to proper value #1486

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Rename param and description to proper value #1486

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b2e129
Rename param and description to proper value
steverao Oct 4, 2024
4e0141c
Fix codestyle problem
steverao Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...spans/src/main/java/io/opentelemetry/contrib/inferredspans/internal/SamplingProfiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,18 +326,19 @@ public boolean onActivation(Span activeSpan, @Nullable Span previouslyActive) {
* <p>This and {@link #onActivation} are the only methods which are executed in a multi-threaded
* context.
*
* @param activeSpan the span which is about to be activated
* @param deactivatedSpan the span which is about to be deactivated
* @param previouslyActive the span which has previously been activated
* @return {@code true}, if the event could be processed, {@code false} if the internal event
* queue is full which means the event has been discarded
*/
public boolean onDeactivation(Span activeSpan, @Nullable Span previouslyActive) {
public boolean onDeactivation(Span deactivatedSpan, @Nullable Span previouslyActive) {
if (profilingSessionOngoing) {
if (previouslyActive == null) {
profiler.removeThread(Thread.currentThread());
}
boolean success =
eventBuffer.tryPublishEvent(deactivationEventTranslator, activeSpan, previouslyActive);
eventBuffer.tryPublishEvent(
deactivationEventTranslator, deactivatedSpan, previouslyActive);
if (!success) {
logger.fine("Could not add deactivation event to ring buffer as no slots are available");
}
Expand Down
Loading