Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Port for the webhook #982

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Set Port for the webhook #982

merged 2 commits into from
Dec 13, 2023

Conversation

jaronoff97
Copy link
Contributor

Although we can set the port on the service, we need to change the validating and mutating webhook configuration as well. cc @TylerHelmuth

@jaronoff97 jaronoff97 requested a review from Allex1 as a code owner December 13, 2023 19:10
@jaronoff97 jaronoff97 requested a review from a team December 13, 2023 19:10
jaronoff97
jaronoff97 commented Dec 13, 2023
View reviewed changes
...perator/examples/default/rendered/admission-webhooks/operator-webhook-with-cert-manager.yaml
@@ -103,6 +106,7 @@ webhooks:
name: example-opentelemetry-operator-webhook
namespace: default
path: /validate-opentelemetry-io-v1alpha1-instrumentation
port: 443
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per the docs, 443 is the default so setting it does nothing

Allex1
Allex1 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@Allex1 Allex1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great find @jaronoff97 👍

@TylerHelmuth TylerHelmuth merged commit e65ca18 into open-telemetry:main Dec 13, 2023
3 checks passed
@jaronoff97 jaronoff97 deleted the make-webhook-port-configurable-2 branch December 13, 2023 19:25
povilasv added a commit to coralogix/opentelemetry-helm-charts that referenced this pull request Feb 9, 2024
@povilasv @TylerHelmuth
@gouthamve @paologallinaharbur @jorgeancal @nrekretep @jankatins @MA3CIN @ahurtaud @JDemler @kevinburkesegment @swiatekm @puckpuck @custompro98 @krisztianfekete @abaguas @galen-reltio @dependabot @codeboten @mx-psi @jinja2 @JaredTan95 @Juliaj @macmiranda @cedricziel @Allex1 @jaronoff97 @datsabk @b3ndill @tomplus @nicolastakashi @dmitryax @ChrsMark @Pionerd @husnialhamdani @hsinhoyeh @LouisParkin @lindeskar
chore: rebase upstream (#63)
64185fd 
* Bump collector version to 0.80.0 (open-telemetry#815)

* [opentelemetry-collector] recombine cri multi-line logs (open-telemetry#818)

* [demo] Bump OTel Collector chart version (open-telemetry#821)

See: open-telemetry#817 (comment)

Signed-off-by: Goutham <[email protected]>

* Feat/extra env from (open-telemetry#820)

* feat(collector-chart): add extraEnvFrom support

* chore(examples): adding examples

* bump operator (open-telemetry#823)

* bump collector (open-telemetry#830)

* JAC: fix checksum config in statefulset template (open-telemetry#827)

* Adds short usage instructions to UPGRADING.md (open-telemetry#826)

* Adds short usage instructions to UPGRADING.md

* Updated chart version and regenerated examples

* Bump operator (open-telemetry#832)

* Fix typo in README.md (open-telemetry#831)

* Add new helm command to README.md, fix typos (open-telemetry#836)

* Add new helm command to README.md, fix typos

+ Add link to logging exporter

* bump operator chart version

* Revert "bump operator chart version"

This reverts commit 91430ff.

* bump operator patch version

* Add externalTrafficPolicy value for service type LoadBalancer (open-telemetry#838)

Signed-off-by: Alban HURTAUD <[email protected]>

* [collector] Respect pipeline order when enabling kubernetesAttributes (open-telemetry#844)

* fix pipeline order when enabling k8sattributes

* bump collector and document breakage

* kubernetesAttributes example

* regenerate examples

* Update charts/opentelemetry-collector/UPGRADING.md

Co-authored-by: Tyler Helmuth <[email protected]>

---------

Co-authored-by: Tyler Helmuth <[email protected]>

* [collector] Allow disabling service even for deployment and statefulset (open-telemetry#843)

* Allow disabling all ports

* temp

* generate examples

* Bump version

* bump collector to 0.82.0 (open-telemetry#847)

* charts/opentelemetry-collector: recommended CPU limit pushes just over threshold (open-telemetry#851)

* charts/opentelemetry-collector: fix CPU limit

While "256m" is a valid setting, the intention was likely to allow
4 pods to be scheduled on a single CPU, which we will currently
overshoot by 24/1000, since there are only 1000 units in a CPU
fraction.

Adjust to "250m", which would allow exactly 4 pods to share a CPU.

See e.g. https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-cpu

* Update charts/opentelemetry-collector/values.yaml

Co-authored-by: Tyler Helmuth <[email protected]>

---------

Co-authored-by: Tyler Helmuth <[email protected]>

* Upgrade operator to v0.82.0 (open-telemetry#854)

* Upgrade operator to v0.82.0

* ci: fix operator E2E tests

* [collector] Allow disabling all ports (open-telemetry#842)

* Allow disabling all ports

* bump patch version instead

* chore(demo): update chart dependencies (open-telemetry#856)

* update chart dependencies

Signed-off-by: Pierre Tessier <[email protected]>

* update chart dependencies

Signed-off-by: Pierre Tessier <[email protected]>

* update chart dependencies

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>

* Bump collector version (open-telemetry#861)

* Update clusterrole (open-telemetry#860)

* mode: daemonset example indicates hostNetwork: true is required (open-telemetry#849)

* add more extraction to preset (open-telemetry#867)

* bump operator version to 0.83.0 (open-telemetry#874)

* [collector] Update readme (open-telemetry#875)

* Update readme with all presets

* Add generic list reminder

* [collector] Update readme and preset comments (open-telemetry#876)

* Update readme and preset comments

* Add links to docs from values.yaml

* Add missed links

* [collector] Make it possible to specify namespace when running Helm template (open-telemetry#871)

* bump collector to 0.84.0 (open-telemetry#883)

* [collector] limit prometheus rules to opentelemetrycollector application (open-telemetry#885)

Signed-off-by: Andre Baptista Aguas <[email protected]>

* [demo] Use k8sattributesprocessor instead of env vars (open-telemetry#817)

* [demo] Use k8sattributesprocessor instead of env vars

Signed-off-by: Goutham <[email protected]>

* Add 0.24 to upgrading.md

Signed-off-by: Goutham <[email protected]>

* Update charts/opentelemetry-demo/UPGRADING.md

---------

Signed-off-by: Goutham <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>

* Bump collector to 0.85.0 (open-telemetry#890)

* [operator]: Update UPGRADING.md (open-telemetry#886) (open-telemetry#888)

* Bump actions/checkout from 3 to 4 (open-telemetry#884)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [demo] - update for 1.5 release (open-telemetry#873)

* update chart dependencies

Signed-off-by: Pierre Tessier <[email protected]>

* update chart dependencies

Signed-off-by: Pierre Tessier <[email protected]>

* use frontendProxy for all communication

Signed-off-by: Pierre Tessier <[email protected]>

* update chart dependencies

Signed-off-by: Pierre Tessier <[email protected]>

* demo 1.5 release

Signed-off-by: Pierre Tessier <[email protected]>

* demo 1.5 release

Signed-off-by: Pierre Tessier <[email protected]>

* demo 1.5 release

Signed-off-by: Pierre Tessier <[email protected]>

* demo 1.5 release

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>

* (demo): update chart dependencies (open-telemetry#893)

* update demo chart dependencies

Signed-off-by: Pierre Tessier <[email protected]>

* update demo chart dependencies

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>

* [operator] bump operator to 0.84.0 (open-telemetry#894)

* update environment variable reference (open-telemetry#898)

* bump operator to 0.85.0 (open-telemetry#896)

* Bump collector to 0.86.0 (open-telemetry#897)

* update charts to use debug exporter (open-telemetry#892)

* update charts to use debug exporter

The logging exporter is being deprecated in favour of the debug
exporter. This changes the charts to use that exporter instead.

Note: this will remain in draft until v0.86.0 is released which will be the first
release to include the debug exporter.

Signed-off-by: Alex Boten <[email protected]>

* make generate-examples CHARTS=opentelemetry-collector

Signed-off-by: Alex Boten <[email protected]>

* update charts

Signed-off-by: Alex Boten <[email protected]>

* revert demo charts

Signed-off-by: Alex Boten <[email protected]>

* bump version for collector/operator charts

Signed-off-by: Alex Boten <[email protected]>

* patch bump

Signed-off-by: Alex Boten <[email protected]>

---------

Signed-off-by: Alex Boten <[email protected]>

* update prometheus to use otlp write (open-telemetry#901)

Signed-off-by: Pierre Tessier <[email protected]>

* [demo] Bump collector chart dep (open-telemetry#903)

* Bump collector chart

* bump version

* Switch to tail mode for logsCollection preset (open-telemetry#904)

* (demo): update grafana dashboards (open-telemetry#902)

* update grafana dashboards

Signed-off-by: Pierre Tessier <[email protected]>

* update grafana dashboards

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>

* [collector] re-add the logging exporter config (open-telemetry#907)

* re-add the logging exporter config

* Add warning in NOTES.txt

* [collector] Remove deprecated fields (open-telemetry#908)

* Remove deprecated fields

* update resources warning

* [collector] Add ability to enable GOMEMLIMIT (open-telemetry#900)

* Add ability to enable GOMEMLIMIT

* remove trailing spaces

* Fix title

* Update charts/opentelemetry-collector/UPGRADING.md

Co-authored-by: Pablo Baeyens <[email protected]>

* Update charts/opentelemetry-collector/UPGRADING.md

Co-authored-by: Pablo Baeyens <[email protected]>

* update warning

* Cleanup merge

* Apply suggestions from code review

Co-authored-by: Jina Jain <[email protected]>

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Jina Jain <[email protected]>

* fix GOMEMLIMIT wrong unit (open-telemetry#913)

* [opentelemetry-operator] Add affinity, tolerations and nodeSelector to tests (open-telemetry#911)

* Add affinity, tolerations and nodeSelector to tests

* Change version from 0.40.0 to 0.39.2

* Generate release notes (open-telemetry#916)

* bump collector version to 0.87.0 (open-telemetry#917)

* fix prometheus endpoint (open-telemetry#920)

Signed-off-by: Pierre Tessier <[email protected]>

* [operator] bump to 0.86.0 (open-telemetry#919)

* (demo) fix jaeger spm and prometheus config (open-telemetry#922)

* fix jaeger spm and prom config

Signed-off-by: Pierre Tessier <[email protected]>

* fix jaeger spm and prom config

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>

* [otel-demo] Include namespace in NOTES.txt (open-telemetry#925)

* Include namespace in NOTES.txt

For full copy & paste, the port-forwarding instructions need to 
include the namespace.

* Bump version && regenerate examples

* [otel-demo] Fix exporter environment variable (open-telemetry#927)

* bump operator version (open-telemetry#926)

* Bump collector to 0.88.0 (open-telemetry#935)

* [collector] Update prometheus alerts (open-telemetry#933)

* upgrade to 0.88 include bridge (open-telemetry#938)

* upgrade to 0.88 include bridge

* facepalm

* Fix testing action

* version fix

* update schema

* add rbac for bridges

* Rename

* install prom CRDs for operator e2e tests

* Fix prometheuscr test

* [demo] add replicas support (open-telemetry#934)

* add replicas support

Signed-off-by: Pierre Tessier <[email protected]>

* note about replicas setting for postgres, kafka, and redis

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>

* [demo] update to demo 1.6 (open-telemetry#942)

* update to demo 1.6

Signed-off-by: Pierre Tessier <[email protected]>

* update to demo 1.6

Signed-off-by: Pierre Tessier <[email protected]>

* update to demo 1.6

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>

* Bump helm/chart-releaser-action from 1.5.0 to 1.6.0 (open-telemetry#944)

Bumps [helm/chart-releaser-action](https://github.com/helm/chart-releaser-action) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/helm/chart-releaser-action/releases)
- [Commits](helm/chart-releaser-action@v1.5.0...v1.6.0)

---
updated-dependencies:
- dependency-name: helm/chart-releaser-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update clusterrole.yaml (open-telemetry#947)

* Adding namespace scope to webhook config (open-telemetry#940)

* add option to reuse previously auto-generated cert (open-telemetry#936)

* add option to reuse previously auto-generated cert

* bump chart version

* autoGenerateCert as object with enabled, ifNotExists properties

* value renamed, ca in secret, logic moved to _helper

* fix default value

* Update upgrade guidelines

* update UPGRADING.md doc

* remove unused file

* Bump collector version to 0.89.0 (open-telemetry#955)

* [CHORE] adding eBPF helm chart (open-telemetry#855)

* [CHORE] adding eBPF helm chart

Signed-off-by: Nicolas Takashi <[email protected]>

* Update .github/workflows/ebpf-test.yaml

Co-authored-by: Tyler Helmuth <[email protected]>

* Update charts/opentelemetry-ebpf/Chart.yaml

Co-authored-by: Tyler Helmuth <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Jared Tan <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Jared Tan <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Jared Tan <[email protected]>

* Update README.md

Co-authored-by: Jared Tan <[email protected]>

* Update README.md

Co-authored-by: Jared Tan <[email protected]>

* Update README.md

Co-authored-by: Jared Tan <[email protected]>

* Update charts/opentelemetry-ebpf/CONTRIBUTING.md

* Update charts/opentelemetry-ebpf/values.yaml

* Update charts/opentelemetry-ebpf/values.yaml

Co-authored-by: Dmitrii Anoshin <[email protected]>

---------

Signed-off-by: Nicolas Takashi <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>
Co-authored-by: Jared Tan <[email protected]>
Co-authored-by: Dmitrii Anoshin <[email protected]>

* [BUMP] Operator v0.89.0/kube-rbac-proxy v0.15.0 (open-telemetry#963)

* [BUMP] Operator v0.89.0/kube-rbac-proxy v0.15.0

* fix

* Add JaredTan95 to approvers list (open-telemetry#965)

* [collector] fix clusterrolebinding binding  wrong namespace (open-telemetry#960)

* fix clusterrolebinding binding  wrong namespace

* remove examples

---------

Co-authored-by: Tyler Helmuth <[email protected]>

* [collector] support add additionalLabels for otel col resources (open-telemetry#968)

* support add additionalLabels for all resources

* add comments

* Update charts/opentelemetry-collector/values.yaml

Co-authored-by: Jina Jain <[email protected]>

* add comments

* Update charts/opentelemetry-collector/values.yaml

Co-authored-by: Tyler Helmuth <[email protected]>

---------

Co-authored-by: Jina Jain <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>

* Bump collector to 0.90.0 (open-telemetry#972)

* Add k8s infra monitorig demo example (open-telemetry#967)

* Add k8s infra monitorig demo example

Signed-off-by: ChrsMark <[email protected]>

* Upgrade chart version

Signed-off-by: ChrsMark <[email protected]>

* Bump patch version instead of minor

Signed-off-by: ChrsMark <[email protected]>

---------

Signed-off-by: ChrsMark <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>

* Bump collector to 0.90.1 (open-telemetry#975)

* Make the service port for the webhook configurable (open-telemetry#976)

* make the service port for the webhook configurable

* service port

* version bump

* version bump the examples

* enable useGOMEMLIMIT by default (open-telemetry#977)

* Bump operator to 0.90.0 (open-telemetry#979)

* Bump operator to 0.90.0

* Fix E2E test runner in CI

* Bump actions/stale from 8 to 9 (open-telemetry#978)

Bumps [actions/stale](https://github.com/actions/stale) from 8 to 9.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v8...v9)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [opentelemetry-collector] update collector to v0.91.0 (open-telemetry#981)

* Set Port for the webhook (open-telemetry#982)

* Set webhook port correctly

* whoops

* [opentelemetry-operator] remove default limits for cpu and memory (open-telemetry#970)

* [opentelemetry-operator] remove default limits for cpu and memory

* adjusted schema and ran make commands

* Updated documentation

Signed-off-by: Pieter van der Giessen <[email protected]>

---------

Signed-off-by: Pieter van der Giessen <[email protected]>

* [demo] update to demo release 1.7 (open-telemetry#983)

* update to demo 1.7

Signed-off-by: Pierre Tessier <[email protected]>

* update to demo 1.7

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>

* polish otel operator WebhookCert logical (open-telemetry#986)

* [operator] fix readme (open-telemetry#987)

* fix readme

* bump chart version

* bump collector to 0.92.0 (open-telemetry#991)

* [operator] Bump operator version to 0.91.0 (open-telemetry#989)

* Bump operator version

* update crds

* bump collector version (open-telemetry#993)

* Use appVersion by default (open-telemetry#994)

* fix grafana dashboards (open-telemetry#1000)

Signed-off-by: Pierre Tessier <[email protected]>

* [collector] Enable `retry_on_failure` for filelog receiver created by logsCollection preset (open-telemetry#999)

* enable filelog with retry_on_failure as default config

Signed-off-by: Husni Alhamdani <[email protected]>

* enable filelog with retry_on_failure as default config

Signed-off-by: Husni Alhamdani <[email protected]>

---------

Signed-off-by: Husni Alhamdani <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>

* demo: add missing namespace on grafana dashboard (open-telemetry#1002)

* demo: add missing namespace on grafana dashboard

fixes: open-telemetry#1001

Signed-off-by: hsinhoyeh <[email protected]>

* add rendered yamls

Signed-off-by: hsinhoyeh <[email protected]>

---------

Signed-off-by: hsinhoyeh <[email protected]>

* [operator] Bump operator version to 0.92.1 (open-telemetry#998)

* Bump operator version to 0.92.0

* update cluster role

* generate examples

* Bump to 0.92.1

* Revert "update cluster role"

This reverts commit 7f43569.

* regenerate

* [collector] Enable HPA when deploy mode is statefulset (open-telemetry#1011)

* [collector] Enable HPA when deploy mode is statefulset

Signed-off-by: Husni Alhamdani <[email protected]>

* [collector] Enable HPA when deploy mode is statefulset

Signed-off-by: Husni Alhamdani <[email protected]>

* Add test scenario for HPA of deployment and statefulset

Signed-off-by: Husni Alhamdani <[email protected]>

---------

Signed-off-by: Husni Alhamdani <[email protected]>

* [demo] add mountedConfigMaps support (open-telemetry#1007)

* add mountedConfigMaps support

Signed-off-by: Pierre Tessier <[email protected]>

* add mountedConfigMaps support

Signed-off-by: Pierre Tessier <[email protected]>

* add mountedConfigMaps support

Signed-off-by: Pierre Tessier <[email protected]>

* add mountedConfigMaps support

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Jared Tan <[email protected]>

* explicitly set healthcheck extension endpoint (open-telemetry#1012)

* [opentelemetry-collector] Fix calculation for gomemlimit (open-telemetry#1015)

* set gomemlimit correctly

* minor fixes

* update chart version

* update var

* remove unittest

* remove unittest

* [collector] bump appVersion to 0.93.0 (open-telemetry#1018)

* Allow for secure deployments by default. (open-telemetry#1019)

* Allow for secure deployments by default.

* Restored data added during testing to original state.

* Updated demo chart README.md.

* Added additional comments to values.yaml to illustrate how the new feature can be used.

* Executed "make generate-examples" and pushing results.

* [opentelemetry-collector] fix HPA kind for StatefulSet mode (open-telemetry#1025)

* add helper to set kind in HPA

* update autoscaling comment in values

* bump version

* [operator] Bump operator to 0.93.0 (open-telemetry#1027)

* bump operator to 0.93.0

* Update collector version

---------

Signed-off-by: Goutham <[email protected]>
Signed-off-by: Alban HURTAUD <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Andre Baptista Aguas <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Nicolas Takashi <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: Pieter van der Giessen <[email protected]>
Signed-off-by: Husni Alhamdani <[email protected]>
Signed-off-by: hsinhoyeh <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>
Co-authored-by: Goutham Veeramachaneni <[email protected]>
Co-authored-by: PaoloGallina <[email protected]>
Co-authored-by: Jorge Andreu Calatayud <[email protected]>
Co-authored-by: Peter Kern <[email protected]>
Co-authored-by: Jan Katins <[email protected]>
Co-authored-by: Marcin Ziółkowski <[email protected]>
Co-authored-by: Alban Hurtaud <[email protected]>
Co-authored-by: Jakob Demler <[email protected]>
Co-authored-by: Kevin Burke <[email protected]>
Co-authored-by: Mikołaj Świątek <[email protected]>
Co-authored-by: Pierre Tessier <[email protected]>
Co-authored-by: Mitch <[email protected]>
Co-authored-by: Krisztian Fekete <[email protected]>
Co-authored-by: André Águas <[email protected]>
Co-authored-by: Goutham Veeramachaneni <[email protected]>
Co-authored-by: galen-reltio <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Boten <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Jina Jain <[email protected]>
Co-authored-by: Jared Tan <[email protected]>
Co-authored-by: Julia Jia <[email protected]>
Co-authored-by: Marco Aurelio Caldas Miranda <[email protected]>
Co-authored-by: Cedric Ziel <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Jacob Aronoff <[email protected]>
Co-authored-by: Abhishek <[email protected]>
Co-authored-by: Grétar Hauksson <[email protected]>
Co-authored-by: Tomasz Prus <[email protected]>
Co-authored-by: Nicolas Takashi <[email protected]>
Co-authored-by: Dmitrii Anoshin <[email protected]>
Co-authored-by: Chris Mark <[email protected]>
Co-authored-by: Pieter <[email protected]>
Co-authored-by: Husni Alhamdani <[email protected]>
Co-authored-by: hsinhoyeh <[email protected]>
Co-authored-by: Louis Parkin <[email protected]>
Co-authored-by: Alexander Lindeskär <[email protected]>
12ushan pushed a commit to giffgaff/opentelemetry-helm-charts that referenced this pull request Jul 22, 2024
@jaronoff97 @12ushan
Set Port for the webhook (open-telemetry#982)
e141bbf 
* Set webhook port correctly

* whoops
@renovate renovate bot mentioned this pull request Sep 3, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@Allex1 Allex1 Allex1 approved these changes

@DanTulovsky DanTulovsky DanTulovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaronoff97 @DanTulovsky @Allex1 @TylerHelmuth