chore(collector): upgrade to app version 0.37.1 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies. Was blocked in going through the necessary hoops to get the CLA signed. That said, happy to defer to your merge that does similarly. Note that upgrading to 0.36.0 additionally requires some configuration syntax changes (see https://github.com/open-telemetry/opentelemetry-helm-charts/pull/80/files#diff-d3c8687b50b2f7b2ca10ff878367b16b76ead0cfdf62548091b5bcc507dc2d68L114). |
|
@bbeattie-phxlabs Thx! Missed that one. |
|
No worries. Might also be worth looking into the feedback provided in the other pull request, e.g. #80 (comment) |
|
The feedback has been already worked into this PR. This PR bumps the version by a minor release and 0.36.0 is available on Dockerhub with the tag |
dmitryax
reviewed
Oct 15, 2021
dmitryax
reviewed
Oct 19, 2021
secustor
changed the title
dmitryax
reviewed
Oct 19, 2021
etiennejournet
pushed a commit
to etiennejournet/opentelemetry-helm-charts
that referenced
this pull request
Oct 28, 2021
* fix(collector): wrap tls insecure value inside tls block * feat(collector): use contrib collector image by default * fix(collector): adapt file logger configuration to v0.36.0 * fix(collector): add memory_ballast to service.extension list * chore(collector): upgrade to v0.37.1 * refactor(collector): add memory_ballast to service extensions statically * Remove ballast_size_mib from memory_limiter Co-authored-by: Dmitry <[email protected]>
etiennejournet
pushed a commit
to etiennejournet/opentelemetry-helm-charts
that referenced
this pull request
Oct 28, 2021
* fix(collector): wrap tls insecure value inside tls block * feat(collector): use contrib collector image by default * fix(collector): adapt file logger configuration to v0.36.0 * fix(collector): add memory_ballast to service.extension list * chore(collector): upgrade to v0.37.1 * refactor(collector): add memory_ballast to service extensions statically * Remove ballast_size_mib from memory_limiter Co-authored-by: Dmitry <[email protected]>
matej-g
pushed a commit
to matej-g/opentelemetry-helm-charts
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #80 seems to be abandoned I have created this new PR to accommodate the changes in the meantime.
appVersion is now prefixed with
vas the tagging has changed with version 0.36.0@dmitryax
Fixes #88
Fixes #42