-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[demo] - set memory limits #444
[demo] - set memory limits #444
Conversation
Is there a way to just have it take everything from the PR branch for the generated files in the merge conflict or am I better off just doing a new PR? Manually resolving 30+ conflicts on generated files seems excessive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@puckpuck how did you decide what the limits should be?
This PR on the demo has details on what I did to determine memory usage for all services |
This sets memory limits for all components including Jaeger and the Collector in line with what is set in the OpenTelemetry demo. Ref: open-telemetry/opentelemetry-demo#460