Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] - set memory limits #444

Merged
merged 11 commits into from
Oct 19, 2022

Conversation

puckpuck
Copy link
Contributor

This sets memory limits for all components including Jaeger and the Collector in line with what is set in the OpenTelemetry demo. Ref: open-telemetry/opentelemetry-demo#460

Verified

This commit was signed with the committer’s verified signature.
puckpuck Pierre Tessier
@puckpuck puckpuck requested a review from a team October 19, 2022 04:34
@puckpuck
Copy link
Contributor Author

Is there a way to just have it take everything from the PR branch for the generated files in the merge conflict or am I better off just doing a new PR? Manually resolving 30+ conflicts on generated files seems excessive.

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@puckpuck how did you decide what the limits should be?

charts/opentelemetry-demo/values.yaml Show resolved Hide resolved
@puckpuck
Copy link
Contributor Author

@puckpuck how did you decide what the limits should be?

This PR on the demo has details on what I did to determine memory usage for all services
open-telemetry/opentelemetry-demo#460

@TylerHelmuth TylerHelmuth merged commit be99cd4 into open-telemetry:main Oct 19, 2022
@puckpuck puckpuck deleted the demo.memory-limits branch October 19, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants