-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permissions to read Job owner #1066
Conversation
Thanks for your contribution @janario but I think you would need to have this change merged first in https://github.com/open-telemetry/opentelemetry-operator/blob/main/config/rbac/role.yaml |
93fdc57
to
0d56957
Compare
Back on this one. @Allex1 now that the operator is merged open-telemetry/opentelemetry-operator#2716 Doesn't the rbac get updated by some process while updating the operator or is it handled manually? |
@janario we currently update the role manually from the operator repo . Can you please bump the chart version and run |
done ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure you rebase
5fb29f2
to
0f1de87
Compare
done 👍 |
@janario I believe this RBAC change is only relevent on the newly released 0.97.0 version of the collector, is that correct? If so, @jaronoff97 you'll need these changes in #1113 |
yes, correct Fine for me to go in the other PR too, |
Together with open-telemetry/opentelemetry-operator#2716
In order to be able to collect the owner of a Job the manager would need to have the proper permissions.
In this PR we add the read Job permissions so in future release of Operator we can improve to get the Job owner.