Skip to content

Commit

Permalink
charts/opentelemetry-collector: fix CPU limit
Browse files Browse the repository at this point in the history
While "256m" is a valid setting, the intention was likely to allow
4 pods to be scheduled on a single CPU, which we will currently
overshoot by 24/1000, since there are only 1000 units in a CPU
fraction.

Adjust to "250m", which would allow exactly 4 pods to share a CPU.

See e.g. https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-cpu
  • Loading branch information
kevinburkesegment committed Aug 7, 2023
1 parent 3c5e341 commit 1a5e3fb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
5 changes: 3 additions & 2 deletions charts/opentelemetry-collector/UPGRADING.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Upgrade guidelines

These upgrade guidelines only contain instructions for version upgrades which require manual modifications on the user's side.
If the version you want to upgrade to is not listed here, then there is nothing to do for you.
If the version you want to upgrade to is not listed here, then there is nothing to do for you.
Just upgrade and enjoy.

## 0.62 to 0.63
Expand Down Expand Up @@ -47,7 +47,8 @@ As of v0.54.0 Collector chart, the default resource limits are removed. If you w
```
resources:
limits:
cpu: 256m
# CPU units are in fractions of 1000; memory in powers of 2
cpu: 250m
memory: 512Mi
```

Expand Down
3 changes: 2 additions & 1 deletion charts/opentelemetry-collector/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,8 @@ ports:
resources: {}
# resources:
# limits:
# cpu: 256m
# # CPU units are in fractions of 1000; memory in powers of 2
# cpu: 250m
# memory: 512Mi

podAnnotations: {}
Expand Down

0 comments on commit 1a5e3fb

Please sign in to comment.