Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/stretchr/testify from 1.4.0 to 1.6.1 in /exporters/otlp #817

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 15, 2020

Bumps github.com/stretchr/testify from 1.4.0 to 1.6.1.

Release notes

Sourced from github.com/stretchr/testify's releases.

Fixes breaking change with HTTPBodyContains

A breaking change was accidentally released in v1.6.0 which breaks the API for the HTTPBodyContains and HTTPBodyNotContains, this release reverts that change.

v1.6.0

Latest release of testify. This includes many fixes and enhancements. Please view the v1.6.0 milestone for a list of changes.

HOTFIX: Revert suite interface type

This is a hotfix which reverts the suite package's interface type to use testing.T

v1.5.0

Latest, non-breaking changes merged into master. Please peruse the git log for a detailed changelist

Commits
  • f654a91 Update Go versions in Travis
  • 3184a9e This reverts commit 0a813b5898c0ee8d00b4f13fae21ea5df8b35e74.
  • e2b269e This reverts commit 2adb7b54b75da2c74e9342ed115957fe0b07e0b4.
  • 6353e56 This reverts commit 9d083cac4a26c76f8d92dff41d459f3f2fc0b911.
  • 6561324 This reverts commit 484fff1ace1f0acb84676a548b53477685c16414.
  • 46420cf This reverts commit 1a43b8334acb9df58064b765cd16675cc7c2c8b3.
  • 303198d Revert "allow body for HTTPBodyContains and HTTPBodyNotContains for
  • e7cc868 Update TravisCI config
  • 004e3cb commit generated files
  • ac1463f Implement NotEqualValues
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 15, 2020
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 15, 2020

CLA Check
The committers are authorized under a signed CLA.

@dependabot dependabot bot force-pushed the dependabot/go_modules/exporters/otlp/github.com/stretchr/testify-1.6.1 branch 2 times, most recently from 4aa6b42 to 9d51811 Compare June 22, 2020 17:02
@evantorrie evantorrie added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Jun 22, 2020
@lizthegrey
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/exporters/otlp/github.com/stretchr/testify-1.6.1 branch from 5aed13c to 6ffc2fd Compare June 22, 2020 18:42
@lizthegrey lizthegrey added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Jun 22, 2020
@dependabot dependabot bot force-pushed the dependabot/go_modules/exporters/otlp/github.com/stretchr/testify-1.6.1 branch from 6ffc2fd to 386072c Compare June 22, 2020 18:56
@dependabot dependabot bot force-pushed the dependabot/go_modules/exporters/otlp/github.com/stretchr/testify-1.6.1 branch from 386072c to e9c1e8e Compare June 22, 2020 19:01
@lizthegrey lizthegrey added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Jun 22, 2020
@lizthegrey
Copy link
Member

lizthegrey commented Jun 22, 2020

@evantorrie this is a legit diff -- when a version of a dep is updated such that a transitive dep is explicit via gomodules rather than indirect, go.mod will need to change to remove the // indirect line.

@lizthegrey lizthegrey added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Jun 22, 2020
@evantorrie
Copy link
Contributor

@evantorrie this is a legit diff -- when a version of a dep is updated such that a transitive dep is explicit via gomodules rather than indirect, go.mod will need to change to remove the // indirect line.

Yes - the mod-tidybot is not smart enough to recognize this case yet - so will still stop and complain.
I would probably need to build quite a bit more smarts into the action to make it recognize this as legitimate - not sure it's worth the effort given the general success rate.

@lizthegrey lizthegrey merged commit 14003ff into master Jun 22, 2020
@lizthegrey lizthegrey deleted the dependabot/go_modules/exporters/otlp/github.com/stretchr/testify-1.6.1 branch June 22, 2020 20:50
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants