Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass Resources through the metrics export pipeline #659

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Pass Resources through the metrics export pipeline #659

merged 2 commits into from
Apr 24, 2020

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Apr 23, 2020

This is a redo of #640, now greatly simplified by the refactoring in #651.

@jmacd jmacd added the area:metrics Part of OpenTelemetry Metrics label Apr 23, 2020
MrAlias
MrAlias approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jmacd jmacd merged commit 3008c1b into open-telemetry:master Apr 24, 2020
@jmacd jmacd deleted the jmacd/resource2 branch April 24, 2020 16:44
@jmacd jmacd mentioned this pull request Apr 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krnowak krnowak krnowak approved these changes

@MrAlias MrAlias MrAlias approved these changes

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@rghetia rghetia Awaiting requested review from rghetia

@tedsuo tedsuo Awaiting requested review from tedsuo

Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmacd @krnowak @MrAlias