Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure spans created by httptrace client tracer reflect operation structure #618

Merged
merged 5 commits into from
Apr 7, 2020

Conversation

Aneurysm9
Copy link
Member

Fixes #152.

Copy link
Member

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks, otherwise looks ok.

plugin/httptrace/clienttrace.go Outdated Show resolved Hide resolved
plugin/httptrace/clienttrace.go Outdated Show resolved Hide resolved
plugin/httptrace/clienttrace.go Outdated Show resolved Hide resolved
@rghetia rghetia merged commit c8ec530 into open-telemetry:master Apr 7, 2020
@Aneurysm9 Aneurysm9 deleted the OTG-152 branch April 7, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP client plugin's spans should reflect behavioural structure
4 participants