Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure TraceProvider with resource and export resource via otlp #545

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Configure TraceProvider with resource and export resource via otlp #545

merged 1 commit into from
Mar 13, 2020

Conversation

rghetia
Copy link
Contributor

@rghetia rghetia commented Mar 12, 2020

fixes #516

  • Configure Trace Provider with Resources
  • Export resource for trace in OTLP exporter
  • Export resource in Jaeger Exporter (another PR)
  • Export resource in Stdout Exporter (another PR)

MrAlias
MrAlias reviewed Mar 13, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Most of my comments are minor nits, but the otlp_test.go questions about checking for maximum instead of equality and the for loop range are both ones I'm interested to better understand.

sdk/trace/config.go Outdated Show resolved Hide resolved
sdk/export/trace/trace.go Outdated Show resolved Hide resolved
exporters/otlp/otlp_test.go Outdated Show resolved Hide resolved
exporters/otlp/otlp_test.go Outdated Show resolved Hide resolved
exporters/otlp/otlp_test.go Outdated Show resolved Hide resolved
exporters/otlp/mock_collector_test.go Outdated Show resolved Hide resolved
MrAlias
MrAlias approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, great work! 💯

@rghetia
add resource option to Provider.
941d152 
- update otlp exporter to export resources.
@rghetia rghetia force-pushed the provider_with_resource branch from 1ee66fa to 941d152 Compare March 13, 2020 20:02
@rghetia rghetia merged commit 6ada85a into open-telemetry:master Mar 13, 2020
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@jmacd jmacd jmacd approved these changes

@krnowak krnowak Awaiting requested review from krnowak

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@tedsuo tedsuo Awaiting requested review from tedsuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

Default SDK support for resources (Tracing)
4 participants
@rghetia @jmacd @MrAlias @pellared