Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/log: Fix doc for LoggerProvider.ForceFlush and LoggerProvider.Shutdown #5259

Merged
merged 2 commits into from
Apr 23, 2024
Merged

sdk/log: Fix doc for LoggerProvider.ForceFlush and LoggerProvider.Shutdown #5259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
998d5a9
sdk/log: Fix doc for LoggerProvider.ForceFlush and LoggerProvider.Shu…
pellared Apr 23, 2024
c310c35
Update sdk/log/provider.go
pellared Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/log/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func (p *LoggerProvider) Logger(name string, opts ...log.LoggerOption) log.Logge
return l
}

// Shutdown flushes queued log records and shuts down the decorated expoter.
// Shutdown shuts down the provider and all processors.
//
// This method can be called concurrently.
func (p *LoggerProvider) Shutdown(ctx context.Context) error {
Expand All @@ -145,9 +145,9 @@ func (p *LoggerProvider) Shutdown(ctx context.Context) error {
return err
}

// ForceFlush flushes all exporters.
// ForceFlush flushes all processors.
//
// This method can be called concurrently.
// This method can be called concurrently.
func (p *LoggerProvider) ForceFlush(ctx context.Context) error {
if p.stopped.Load() {
return nil
Expand Down