Add benchmark for logger #5101
Merged
Add benchmark for logger #5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSAM
requested review from
MrAlias,
Aneurysm9,
evantorrie,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
XSAM
commented
Mar 25, 2024
pellared
approved these changes
Mar 26, 2024
dmathieu
approved these changes
Mar 26, 2024
MrAlias
approved these changes
Mar 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5101 +/- ##
=====================================
Coverage 83.8% 83.8%
=====================================
Files 248 248
Lines 16201 16201
=====================================
+ Hits 13579 13581 +2
+ Misses 2334 2332 -2
Partials 288 288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #5054
part of #5082
$ benchstat /tmp/old.txt goos: darwin goarch: arm64 pkg: go.opentelemetry.io/otel/sdk/log │ /tmp/old.txt │ │ sec/op │ LoggerNewRecord/5_attributes-10 12.18n ± 2% LoggerNewRecord/10_attributes-10 234.7n ± 1% geomean 82.95n │ /tmp/old.txt │ │ B/op │ LoggerNewRecord/5_attributes-10 0.000 ± 0% LoggerNewRecord/10_attributes-10 608.0 ± 0% geomean ¹ ¹ summaries must be >0 to compute geomean │ /tmp/old.txt │ │ allocs/op │ LoggerNewRecord/5_attributes-10 0.000 ± 0% LoggerNewRecord/10_attributes-10 4.000 ± 0%