Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate unknown trace flag bits #5075

Closed
wants to merge 3 commits into from

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Mar 14, 2024

resolves #5030

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.2%. Comparing base (ca35244) to head (249603e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5075     +/-   ##
=======================================
- Coverage   83.2%   83.2%   -0.1%     
=======================================
  Files        243     243             
  Lines      15909   15908      -1     
=======================================
- Hits       13246   13245      -1     
  Misses      2375    2375             
  Partials     288     288             
Files Coverage Δ
propagation/trace_context.go 96.9% <100.0%> (-0.1%) ⬇️

@MrAlias
Copy link
Contributor

MrAlias commented Mar 14, 2024

Doesn't this violate this:

... [t]he vendor will only parse the trace-flags values supported by this version of this specification and ignore all other values. [...] Vendors will set all unparsed / unknown trace-flags to 0 on outgoing requests.

@XSAM XSAM closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagate 8 bits of W3C trace context flags
5 participants