-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
design: log value accessors must not panic #4948
design: log value accessors must not panic #4948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure this is necessary to have in the design doc, but i'm not against it if you think that was unclear.
I think it won't hurt and documents why it is different than e.g. slog's value accessors: https://pkg.go.dev/log/slog#Value.Bool |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4948 +/- ##
=======================================
- Coverage 82.6% 82.6% -0.1%
=======================================
Files 238 238
Lines 19036 19036
=======================================
- Hits 15742 15740 -2
- Misses 3003 3005 +2
Partials 291 291 |
Towards #4914
I also updated the prototype with 147762f